[PATCH] 1.3.34-dev mod_log_forensic.c to use ap_assert

[Jim Jagielski]

Anyone have any comments on the below?


Index: src/modules/standard/mod_log_forensic.c
===================================================================
RCS file: /home/cvs/apache-1.3/src/modules/standard/mod_log_forensic.c,v
retrieving revision 1.8
diff -u -r1.8 mod_log_forensic.c
--- src/modules/standard/mod_log_forensic.c     27 Aug 2004 23:49:39 -0000      
1.8
+++ src/modules/standard/mod_log_forensic.c     14 Nov 2004 18:45:55 -0000
@@ -28,7 +28,6 @@
 #include "httpd.h"
 #include "http_config.h"
 #include "http_log.h"
-#include <assert.h>
 
 #ifdef NETWARE
 #include "test_char.h"
@@ -113,9 +112,9 @@
 static char *log_escape(char *q, const char *e, const char *p)
 {
     for ( ; *p ; ++p) {
-        assert(q < e);
+        ap_assert(q < e);
         if (test_char_table[*(unsigned char *)p]&T_ESCAPE_FORENSIC) {
-            assert(q+2 < e);
+            ap_assert(q+2 < e);
             *q++ = '%';
             sprintf(q, "%02x", *(unsigned char *)p);
             q += 2;
@@ -123,7 +122,7 @@
         else
             *q++ = *p;
     }
-    assert(q < e);
+    ap_assert(q < e);
     *q = '\0';
 
     return q;
@@ -212,7 +211,7 @@
 
     ap_table_do(log_headers, &h, r->headers_in, NULL);
 
-    assert(h.pos < h.end);
+    ap_assert(h.pos < h.end);
     *h.pos++ = '\n';
 
     write(cfg->fd, h.log, h.count-1);
-- 
===========================================================================
   Jim Jagielski   [|]   [EMAIL PROTECTED]   [|]   http://www.jaguNET.com/
      "A society that will trade a little liberty for a little order
             will lose both and deserve neither" - T.Jefferson