[EMAIL PROTECTED] wrote:
> Eli Marmor wrote:
>
> [..cut..]
>
> >
> > In addition, the "entity" must be updated to contain more attributes of
> > the request (args, POST args, cookies, etc.). And to find it fast, the
> > key generated by cache_generate_key must be based on more things (such
> > as args). Because sometimes a dynamic site may have thousands pages,
> > all of them with the same URL but with different args.
>
> The args are already used by cache_generate_key (see cache_storage.c lines 301
> till 310, code from 2.0.53):
>
> apr_status_t cache_generate_key_default( request_rec *r, apr_pool_t*p,
> char**key )
> {
> if (r->hostname) {
> *key = apr_pstrcat(p, r->hostname, r->uri, "?", r->args, NULL);
> }
> else {
> *key = apr_pstrcat(p, r->uri, "?", r->args, NULL);
> }
> return APR_SUCCESS;
> }
Oops, you're right...
But yet, POST args are not used (it requires an input filter BTW), as
well as other parameters which may affect "dynamic" caching (cookies
etc.).
People may be afraid of a total caching and/or input filter, so these
options will be turned off by default, but we still owe them for the
rest.
--
Eli Marmor
[EMAIL PROTECTED]
Netmask (El-Mar) Internet Technologies Ltd.
__________________________________________________________
Tel.: +972-9-766-1020 8 Yad-Harutzim St.
Fax.: +972-9-766-1314 P.O.B. 7004
Mobile: +972-50-5237338 Kfar-Saba 44641, Israel
