André Malo <[EMAIL PROTECTED]> writes:
[...]
> One should use the ap_ variants throughout httpd and these macros help
> to identify the bare variants without ap_ prefix.
If that's the policy, it's clearly not being enforced. But if it were
1) Wouldn't it be better to use #error than to silently redefine everything?
2) Why export AP_DEBUG via apxs? How about at least adding a
CORE_PRIVATE wrapper or something?
3) Why export this policy at all? What's wrong with grep?
> At least these were the initial reasons for them. If they no longer
> apply, forget my -1.
My impression of what these macros are being used for does not
match yours. I think these macros are there to allow httpd
developers to use the common str* names in their source code,
but also to ensure that the aren't silently converting a const
string into a non-const one. The problem I have with this is that
httpd is exporting these helpers, where the change in linkage
(from stdlib to httpd) may be disastrous.
--
Joe Schaefer
