[EMAIL PROTECTED] wrote:
Author: soc-rian
Date: Mon Aug 22 20:38:56 2005
New Revision: 239318

URL: http://svn.apache.org/viewcvs?rev=239318&view=rev
Log:
Made smtpd_run_queue a RUN_ALL hook (so multiple plugins can handle the message)

This is another example of a change that makes numerous unrelated whitespace changes which obscure the actual change in functionality, making it difficult to read. I don't have any particular objection to the whitespace changes, but they should have been made in a separate commit. This kind of thing only takes a little bit of effort on your part, but it makes it far far easier (and thus more likely) for other developers to review the change and verify that it is correct.

-garrett

Reply via email to