On Mon, 2005-10-03 at 15:40 -0400, Brian Akins wrote: > Ondrej Sury wrote: > > > Just quick thought, maybe we should add: > > > > ap_log_writer_close *close; > > > > to struct log_provider_t. It's not absolutely necessary, because you > > can use apr_pool_cleanup_register(...), but it will make writing addon > > modules much cleaner. > > That's debatable. I already use apr_pool_cleanup_register in a lot of > stuff, so it seems "natural" to me. I guess we could register a cleanup > on each cls that called close or we could let the module developer do > it... I'm leaning toward just letting others register the cleanup on > there own like buffered logs does now.
Disadvantage of having it outside cls->provider is that you have to keep list of opened connections/files/sockets/etc. somewhere and you will be duplicating this list if you keep it outside of multi_log_state. Anyway it's not a big deal since connections to server will be propably opened in init_child. Ondrej. -- Ondrej Sury <[EMAIL PROTECTED]>
signature.asc
Description: This is a digitally signed message part
