On Wed, Dec 07, 2005 at 03:48:39PM -0000, [EMAIL PROTECTED] wrote:
> + * proxy_util: Fix case where a shared keepalive connection results in
> + different (and incorrect) workers from being accessed.
> +
> http://svn.apache.org/viewcvs.cgi/httpd/httpd/trunk/modules/proxy/proxy_util.c?rev=350250&view=diff&r1=350250&r2=332306
> + +1: jim
In reviewing this, I can't for the life of me figure out why there's an if
and else check that has the exact same body. Can't we just do:
if (!conn->hostname || !worker->is_address_reusable ||
(r->connection->keepalives &&
(r->proxyreq == PROXYREQ_PROXY || r->proxyreq == PROXYREQ_REVERSE) &&
(strcasecmp(conn->hostname, uri->hostname) != 0))) {
....
}
With a conditional like this, it'd probably be nice to have the conditional
tests in a comment so that we can understand the check that it's doing. =)
Or, am I missing something? -- justin
