Graham Leggett wrote:
>
> > Index: modules/cache/mod_disk_cache.c
> > ===================================================================
> > --- modules/cache/mod_disk_cache.c (revision 356419)
> > +++ modules/cache/mod_disk_cache.c (working copy)
> > @@ -1010,7 +1010,7 @@
> > * sanity checks.
> > */
> > if (APR_BUCKET_IS_EOS(APR_BRIGADE_LAST(bb))) {
> > - if (r->connection->aborted) {
> > + if (r->connection->aborted || r->no_cache) {
> > ap_log_error(APLOG_MARK, APLOG_INFO, 0, r->server,
> > "disk_cache: Discarding body for URL %s "
> > "because connection has been aborted.",
> >
>
> Would mem_cache have to do the same thing? Is there not a way to make
> this generic?
>
> Otherwise +1.
>
Not really, at least as far as I can see (yet! :) ). The reason is
that what we use to trigger a "error happened, don't cache" is
the no_cache flag, and so each would need to check that (which
they should be doing anyway, imo ;) )
--
=======================================================================
Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/
"If you can dodge a wrench, you can dodge a ball."
