On Feb 8, 2006, at 10:56 AM, Brian J. France wrote:
+1, I like the idea of the storing the setting in the per
connection instance. Leaving the default in the core and copying
it to an per connection struct would allow modules to tweak the
setting per connection.
One other addition to the smtpd_session_rec I would like to see
would be something like r->notes or r->subprocess_env. Some way
for modules to set flags that would change the behavior of another
module. As an example I might want to add a new modules that
changes the max data size based on either connection ip or mail
from address. This module would want to set a flag telling the
size module to not show the numerical size limit in the ehlo
response as it might change based on the the mail from address.
Something like r->notes does exist, check scr->session_config.
+1, if I understand you currently. Changing scr->should_disconnect
to scr->allows_commands which is a bit-field of what commands that
are allowed. Then smtp_protocol.c handles denying command instead
of having a module hook every command and doing it, right?
Yeah exactly right!
Rian
