On 07/24/2006 09:15 AM, Joe Orton wrote: > On Sun, Jul 23, 2006 at 06:54:33PM +0100, Ben Laurie wrote: > >>Ruediger Pluem wrote: >> >>>On 07/23/2006 02:10 PM, Ben Laurie wrote: >>> >>>>Joe Orton wrote: >>>> >>>>>- use APR apr_file_* not ANSI C fopen, >>>> >>>>I need a FILE *. >>> >>>Maybe you could use BIO_new_file / PEM_read_bio_PKCS7 as it is done in >>>similar >>>situations in other places of mod_ssl. >> >>Why? > > > The <256 fd limit for stdio on Solaris is a good enough reason.
This is a good reason, but to be honest using BIO_new_file does not help, because it uses fopen internally :-(. So the remaining reason for me is consistency with the other parts of the mod_ssl code. > > Current warnings on the trunk are: > > mod_deflate.c: In function 'flush_libz_buffer': > mod_deflate.c:221: warning: 'zRC' may be used uninitialized in this function Thanks Joe. This is mine. Although I think the compiler is wrong in this case, I fixed it in r424950. Regards Rüdiger
