On Sun, 1 Oct 2006, Davi Arnaut wrote:

store_body:
        .. if (is_file_bucket(bucket))
                copy_file_bucket(bucket, bb);

Probably, but that doesn't allow for creating a thread/process that
does the copying in the background, which is my long term goal.

Also, simply doing bucket_delete like that means that the file will
never be sent to the client, which is a bad thing IMO ;)

Shame on me, but I said "something like".. :)

I guess the attached patch does the same (plus mmap, et cetera) and is
much simpler. Comments ?

Simpler, yes. But it only has the benefit of not eating all your memory...

* It leaves the brigade containing the uncached entity, so it will
  cause the backend to first deliver stuff to be cached and then stuff
  to the client.
* When this evolves to wanting to spawn a thread/process to do the
  copying you'll need the "is this a file"-thingie anyway (at least I
  need it, but I might have missed some nifty feature in APR).

/Nikke
--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
 Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se      |     [EMAIL PROTECTED]
---------------------------------------------------------------------------
 "Oohhh.  Jedi Master.  Yoda.  You seek Yoda."
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Reply via email to