On Fri, Oct 27, 2006 at 11:38:02AM -0300, Davi Arnaut wrote:
> > + /* Is our network connection still alive?
> > + * If not, we must continue caching the file, so keep
> > looping.
> > + * We will return the error at the end when caching is
> > done.
> > + */
> > + if (APR_SUCCESS == dobj->frv) {
> > +
> > + /* insert a file bucket pointing to the cache into out
> > temporary brigade */
> > + if (diskcache_brigade_insert(dobj->tmpbb, dobj->fd,
> > dobj->file_size,
> > + written,
> > + dobj->updtimeout,
> > r->pool) == NULL) {
> > + return APR_ENOMEM;
> > + }
>
> Err. We had the data in memory, we are going to read it back from disk
> again just in order to not block ? That's nonsense.
Agreed.
> We don't need a special bucket type!
Agreed. So -1 on this, on r462696, and on r450105.
joe
