Jim Jagielski wrote: > William A. Rowe, Jr. wrote: >>> The other fatal bug is: >>> >>>> * mpm_winnt: Fix return values from wait_for_many_objects. >>>> http://svn.apache.org/viewvc?view=rev&revision=428029 >>>> 2.2.x version of patch: >>>> Trunk version works >>>> + http://people.apache.org/~wrowe/mpm_winnt_waits.patch >>>> + is easier to read (-U8) >>>> +1: mturk, wrowe >>> Which i've created another, easier-to-read example of the backport, if you >>> didn't follow the change last time please read the new patch and chime in >>> a third +1? You'll note it's simply a matter of unsetting errno before we >>> invoke the wait, so we know if the 64th, 128th, etc are real errors or in >>> fact indexes into the wait list array. >>> >>> That's it. I'd like to roll tonight so the vote can be closed by the 22nd. >> I'd like to have was dependent on someone tossing in a vote here /shrug. > > I could vote +1 by inspection, but I can't test...
Of course... had I expected anyone would test, I wouldn't have wasted the time and effort to generate a legigble diff -U8 - which by the way is somewhat tricky... svn diff --diff-cmd=diff --extentions=-U8 are both required since the built-in-diff'er doesn't know -u8 or -U8, and the diff-cmd is an app path/name, not a command line. Guess it was worth wasting the time to learn this even if this exercise doesn't have any net results.
