We have positive confirmation now that this solution restores the behavior of httpd 2.2.3, reverting one small aspect of the post-2.2.3 major overhaul of mod_isapi (return OK from the handler).
Although the introduction of the debugging messages is new (not a reversion), I will go ahead and backport as a platform maintainer's fix later this eve and roll, unless anyone would like to take some time and provide feedback, or otherwise objects. Besides this showstopper, folks are quiet, so I presume nothing else is really a regression or showstopper to a T&R tonight? It looks like we still have lots of behavioral and optimization "meat" to stuff in 2.2.5 after this essential update. Bill William A. Rowe, Jr. wrote: > If anyone has a couple cycles to review this, I'd like to tar up 2.2.4 later > on tonight. Since this was a nasty fault when it occurred (PR 40470) I still > consider it necessary before 2.2 gets bumped. > > Does anyone have other backports to point out that are showstopper quality, > before I T&R? > > Bill > > [EMAIL PROTECTED] wrote: >> Author: wrowe >> Date: Wed Jan 3 14:57:48 2007 >> New Revision: 492338 >> >> URL: http://svn.apache.org/viewvc?view=rev&rev=492338 >> Log: >> Beg for review >> >> Modified: >> httpd/httpd/branches/2.2.x/STATUS >> >> Modified: httpd/httpd/branches/2.2.x/STATUS >> URL: >> http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?view=diff&rev=492338&r1=492337&r2=492338 >> ============================================================================== >> --- httpd/httpd/branches/2.2.x/STATUS (original) >> +++ httpd/httpd/branches/2.2.x/STATUS Wed Jan 3 14:57:48 2007 >> @@ -198,3 +198,17 @@ >> PR: 36609 >> http://svn.apache.org/viewvc?rev=490156&view=rev >> +1: niq >> + >> + * mod_isapi: One last round, vetted against a number of sample ISAPI >> + applications. For the patches to make those PSDK samples work, see >> + >> http://people.apache.org/~wrowe/ms_psdk_feb2003_isapi_sample_bugfixes.diff >> + Resolves PR 40470. >> + Where any response is sent, return OK from the handler. Where there >> + is no response (but a status code) return the code. This patch adds >> + a great number of debugging emits for failed ap_pass_brigade calls, >> + to help diagnose failure cases, and disambiguates OK from >> APR_SUCCESS. >> + Submitted by: wrowe, Matt Eaton <asf divinehawk.com> >> + Patch applies to 2.2 and 2.0 as-is: >> + http://svn.apache.org/viewvc?view=rev&revision=492333 >> + +1: wrowe >> + >> >> >> . >> > >
