Thanks Nick for responding to my request. My comments are in between.
On Wed, Feb 28, 2007 at 10:49:48PM +0000, Nick Kew wrote: > On Wed, 28 Feb 2007 14:31:19 -0800 > Basant Kukreja <[EMAIL PROTECTED]> wrote: > > > Hi, > > I am Basant. I work in web tier group in Sun Microsystems Inc. > > > > I have submitted the patch for bug 39299. > > Summary : Internal Server Error (500) on COPY > > URI : http://issues.apache.org/bugzilla/show_bug.cgi?id=39299 > > > > > > Can some of the committer kindly review my patch please to see if it > > is acceptable or not? > > Patch is against 2.2.x branch. > > 409 implies a condition the client can fix. Your patch tests for > a particular condition that is likely to be fixable in a server > with DAV up&running. But AFAICS it could also give a bogus 409, > for example in the case of a newly-installed and misconfigured > server. Can you kindly elaborate more? How newly misconfigured server can send 409? Here is my test case : DavLockDB /disk/apache/apache2/var/DAVLockFs <Directory "/disk/apache/apache2/htdocs/DAVtest"> Options Indexes FollowSymLinks AllowOverride None order allow,deny allow from all AuthName "SMA Development server" AuthType Basic DAV On </Directory> Now assuming, I misconfigured the server and I intended to configure /DAVtest1 instead of /DAVtest, if I send a request. ---------------------------------------------- COPY /DAVtest1/litmus/copysrc HTTP/1.1 Host: myhostname.mydomain:4004 User-Agent: litmus/0.11 neon/0.25.5 Connection: TE TE: trailers Depth: 0 Destination: http://myhostname.mydomain:4004/DAVtest/litmus/nonesuch/foo Overwrite: F X-Litmus: copymove: 5 (copy_nodestcoll) ---------------------------------------------- I will get a 405 response. ---------------------------------------------- HTTP/1.1 405 Method Not Allowed Date: Thu, 01 Mar 2007 04:12:59 GMT Server: Apache/2.2.5-dev (Unix) mod_ssl/2.2.5-dev OpenSSL/0.9.8a DAV/2 SVN/1.4.3 mod_perl/2.0.4-dev Perl/v5.8.8 Allow: GET,HEAD,POST,OPTIONS,TRACE Content-Length: 245 Content-Type: text/html; charset=iso-8859-1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN"> <html><head> <title>405 Method Not Allowed</title> </head><body> <h1>Method Not Allowed</h1> <p>The requested method COPY is not allowed for the URL /DAVtest1/litmus/copysrc.</p> </body></html> ---------------------------------------------- > > Does the DAV RFC explicitly tell us to use 409 in this instance? I didn't find RFC explictly stating 409 response but it is one of the responses returned by COPY method. I will dig more and return back on this. Regards, Basant. > > -- > Nick Kew > > Application Development with Apache - the Apache Modules Book > http://www.apachetutor.org/
