On 05/18/2007 01:33 AM, Justin Erenkrantz wrote:
>
> With this patch, the only thing mod_cache ever touches is...Age. =)
>
> I'll let this sit here for a bit and if we agree this is right, we can
> commit. -- justin
>
> Index: modules/cache/mod_cache.c
> ===================================================================
> --- modules/cache/mod_cache.c (revision 539156)
> +++ modules/cache/mod_cache.c (working copy)
> @@ -663,21 +663,8 @@
>
> now = apr_time_now();
> if (info->date == APR_DATE_BAD) { /* No, or bad date */
> - char *dates;
> /* no date header (or bad header)! */
> - /* add one; N.B. use the time _now_ rather than when we were
> checking
> - * the cache
> - */
> - if (date_in_errhdr == 1) {
> - apr_table_unset(r->err_headers_out, "Date");
> - }
> - date = now;
Hm. In this case date would be undefined and it is used later on.
Maybe we should remove the else branch and set date = info->date in
any case so that it is either the contents of Date: or now.
Regards
Rüdiger
