>On June 05, 2007 1:45 AM Rüdiger wrote >> On June 04, 2007 5:51 PM David McCreedy wrote:
>> I've figured out why some pids aren't being "unset" and I think it could >> affect other platforms besides TPF. >> They're hitting the else part of the "if (child_slot >= 0)" statement in >> http_main.c's standalone_main function. >> I think the unset_pid_table call should be moved before this "if". >> If we're in this section of code, don't we want to remove the pid from the >> table regardless of whether the slot is found in the scoreboard? > >Yes, we want to. Please have a look at r544218 >(http://svn.apache.org/viewvc?view=rev&revision=544218<http://svn.apache.org/viewvc?view=rev&revision=544218>) > > > Rüdiger Perfect. Thanks, -David ----- Original Message ----- From: Plüm<mailto:Plüm> ; Rüdiger<mailto:Rüdiger> ; VF-Group<mailto:[EMAIL PROTECTED]> To: [email protected]<mailto:[email protected]> Sent: Tuesday, June 05, 2007 1:45 AM Subject: AW: svn commit: r543511 - /httpd/httpd/branches/1.3.x/src/main/http_main.c -----Ursprüngliche Nachricht----- Von: David McCreedy Gesendet: Dienstag, 5. Juni 2007 04:29 An: [email protected]<mailto:[email protected]> Betreff: Re: svn commit: r543511 - /httpd/httpd/branches/1.3.x/src/main/http_main.c June 04, 2007 5:51 PM David McCreedy wrote: >On 06/01/2007 05:42 PM, [EMAIL PROTECTED]<mailto:[EMAIL PROTECTED]> wrote: >> >>I think I squashed those. Could you check out >>trunk and try another test? Thanks! >> > >It fixes the "Bad pid" error but I'm not sure all is well... > >On TPF we're not calling unset_pid_table on SIG_IDLE_KILLs. >I'll have to track down why. > > I've figured out why some pids aren't being "unset" and I think it could affect other platforms besides TPF. > They're hitting the else part of the "if (child_slot >= 0)" statement in http_main.c's standalone_main function. > I think the unset_pid_table call should be moved before this "if". > If we're in this section of code, don't we want to remove the pid from the table regardless of whether the slot is found in the scoreboard? Yes, we want to. Please have a look at r544218 (http://svn.apache.org/viewvc?view=rev&revision=544218<http://svn.apache.org/viewvc?view=rev&revision=544218>) Regards Rüdiger
