Ruediger Pluem wrote:
On 06/27/2007 10:42 AM, [EMAIL PROTECTED] wrote:
Author: jfclere
Date: Wed Jun 27 01:42:02 2007
New Revision: 551099

URL: http://svn.apache.org/viewvc?view=rev&rev=551099
Log:
Remove the balancer modification logic of balancer-manager
because it can't work. And add the sticky_path to the
sticky display.

Modified:
    httpd/httpd/trunk/modules/proxy/mod_proxy.c
    httpd/httpd/trunk/modules/proxy/mod_proxy_balancer.c

Modified: httpd/httpd/trunk/modules/proxy/mod_proxy.c
URL: 
http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy.c?view=diff&rev=551099&r1=551098&r2=551099
==============================================================================
--- httpd/httpd/trunk/modules/proxy/mod_proxy.c (original)
+++ httpd/httpd/trunk/modules/proxy/mod_proxy.c Wed Jun 27 01:42:02 2007
@@ -2068,7 +2068,8 @@
         ap_rputs("\n\n<table border=\"0\"><tr>"
                  "<th>SSes</th><th>Timeout</th><th>Method</th>"
                  "</tr>\n<tr>", r);
-        ap_rvputs(r, "<td>", balancer->sticky, NULL);
+        ap_rvputs(r, "<td>", balancer->sticky, " | ", balancer->sticky_path,
+                  NULL);

IMHO this creates possibly confusing output for the user as if I set 
stickysession to e.g. PHPSESSIONID the
output will be "PHPSESSIONID|PHPSESSIONID". So I guess we need to document 
better that if you do not use
"|" in stickysession that stickysession defaults to
"<stickysession setting configured>|<stickysession setting configured>"
It is possible to test the value and prevent the display of " PHPSESSIONID | PHPSESSIONID" that is not a critical piece of code.

Cheers

Jean-Frederic
Regards

RĂ¼diger





Reply via email to