On 9/24/07, Ruediger Pluem <[EMAIL PROTECTED]> wrote:
>
>
> On 09/24/2007 02:04 PM, Jeff Trawick wrote:
> > On 9/24/07, Ruediger Pluem <[EMAIL PROTECTED]> wrote:
> >>
> >> On 09/23/2007 10:49 PM, Jeff Trawick wrote:
> >>> On 9/18/07, Plüm, Rüdiger, VF-Group <[EMAIL PROTECTED]> wrote:
> >>>>> -----Ursprüngliche Nachricht-----
> >>>>> Von: Adam Hasselbalch Hansen
> >>>>> Gesendet: Dienstag, 18. September 2007 12:25
> >>>>> An: dev@httpd.apache.org
> >>>>> Betreff: [PATCH 43415] Logging remote port.
> >>>>>
> >>>>>
> >>>>> I have created a patch for httpd 2.2.6, giving the additional
> >>>>> LogFormat
> >>>>> directive %R, which logs the port of the host making the request.
> >>>>>
> >>>>> This is due to new legislation in Denmark, requiring ISPs and hosting
> >>>>> companies to log the originating port of all traffic.
> >>>> 5 comments:
> >>>> 3. I am not too happy with using %R, but to be honest I have no better
> >>>> proposal :-).
> >>>> Maybe other have.
> >>> %{canonical}p (default)
> >>> %{local}p
> >>> %{remote}p
> >> Sounds good to me.
> >
> > The attached patch works for me (though I haven't yet rebuilt the docs
> > to see what that looks like).
>
> Patch looks good to me (including docs, which I rebuilt in my working copy),
> but as most of the time some comments :-).
thanks, of course!
> 1. I would use strcasecmp instead of strcmp to avoid case issues in the
> config.
sure; FWIW, some other format string comparisons are not case
insignificant, but those can be checked for in the fullness of time
> 2. We can save a few cycles by using apr_itoa instead of pfmt as IMHO port is
> never
> <= 0.
>
> BTW: I think format_integer should be removed as it is only used by pfmt. It
> can be replaced
> with apr_itoa. Just did this in r578927.
sure; I recall you mentioning apr_itoa() on this thread but I guess I forgot
I'll fix up before long.
Have fun!
