Worse than a leak; conf->pool should be const, touching it explodes the
copy-on-write semantics of the conf pool memory (which otherwise is a
single common resource). There are better pools to abuse, if unavoidable,
such as process pool.
Jeff Trawick wrote:
looks like a leak to me; what do you think?
Index: modules/proxy/mod_proxy_balancer.c
===================================================================
--- modules/proxy/mod_proxy_balancer.c (revision 598305)
+++ modules/proxy/mod_proxy_balancer.c (working copy)
@@ -654,7 +654,7 @@
const char *val;
if ((val = apr_table_get(params, "ss"))) {
if (strlen(val))
- bsel->sticky = apr_pstrdup(conf->pool, val);
+ bsel->sticky = apr_pstrdup(r->pool, val);
else
bsel->sticky = NULL;
}
trunk looks much different here. Does anyone plan to backport the
larger changes to 2.2.x in the near term, or should we go for this
tweak?
