On Nov 27, 2007, at 8:20 AM, Jeff Trawick wrote:
looks like a leak to me; what do you think? Index: modules/proxy/mod_proxy_balancer.c =================================================================== --- modules/proxy/mod_proxy_balancer.c (revision 598305) +++ modules/proxy/mod_proxy_balancer.c (working copy) @@ -654,7 +654,7 @@ const char *val; if ((val = apr_table_get(params, "ss"))) { if (strlen(val)) - bsel->sticky = apr_pstrdup(conf->pool, val); + bsel->sticky = apr_pstrdup(r->pool, val); else bsel->sticky = NULL; } trunk looks much different here. Does anyone plan to backport the larger changes to 2.2.x in the near term, or should we go for this tweak?
It's not a leak but yes all these changes do need to be backported... I simply haven't found the cycles yet, but we should leave the existing code as-is due to the regressions and dumps that will arise. I'll try to propose a backport this week (since we have time) that removes "adjusting" the balancer as well as other low-hanging fruit changes between trunk and 2.2