On Sun, 30 Mar 2008 16:36:28 +0200
Ruediger Pluem <[EMAIL PROTECTED]> wrote:

       PARSE_STRING(r,
> > current->left->token.value);
> > +                    current->left->value
> > = !!*current->left->token.value;
> 
> Why do we use !! here? Isn't this the same as !! not being there?

I don't understand that either, but I guess it could be a hack
for casting char to int.  Ain't broke - not fixing.
 
[broadly the same applies to your other comments]

> General question: I know that this parser was taken from mod_include
> and I haven't really dived into its details, but wouldn't it be
> better and faster for evaluation to build UPN stack from the
> expression instead of the parser tree?

Could well be.  Feel free to dive in and hack it!
My current goal is "works".  "Works optimally" can wait.

-- 
Nick Kew

Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/

Reply via email to