Patch for mod_filter - code does not match documentation

[Andrew Ford]

The documentation for FilterDeclare says that :

    The final (optional) argument is the type of filter, and takes
    values of |ap_filter_type| - namely |RESOURCE| (the default),
    |CONTENT_SET|, |PROTOCOL|, |TRANSCODE|, |CONNECTION| or |NETWORK|.


However there is no code to detect TRANSCODE, and any unknown types are
silently accepted (as RESOURCE).

The attached patch for 2.2.x fixes this.

Andrew

-- 
Andrew Ford                     
South Wing Compton House, Compton Green,
Redmarley, Gloucestershire, GL19 3JB, UK
Tel:    +44 1531 829900
Mobile: +44 7785 258278
Email:  [EMAIL PROTECTED]



Index: modules/filters/mod_filter.c
===================================================================
--- modules/filters/mod_filter.c	(revision 664295)
+++ modules/filters/mod_filter.c	(working copy)
@@ -486,12 +486,18 @@
         else if (!strcasecmp(place, "PROTOCOL")) {
             filter->ftype = AP_FTYPE_PROTOCOL;
         }
+        else if (!strcasecmp(place, "TRANSCODE")) {
+            filter->ftype = AP_FTYPE_TRANSCODE;
+        }
         else if (!strcasecmp(place, "CONNECTION")) {
             filter->ftype = AP_FTYPE_CONNECTION;
         }
         else if (!strcasecmp(place, "NETWORK")) {
             filter->ftype = AP_FTYPE_NETWORK;
         }
+	else if (strcasecmp(place, "RESOURCE")) {
+            return apr_psprintf(cmd->pool, "Unknown filter-type %s", place);
+	}
     }
 
     return NULL;