On Jan 30, 2009, at 3:07 PM, Ruediger Pluem wrote:
On 01/30/2009 03:48 AM, [email protected] wrote:
Author: fielding
Date: Fri Jan 30 02:48:08 2009
New Revision: 739150
URL: http://svn.apache.org/viewvc?rev=739150&view=rev
Log:
revert r711228: the ap_unixd_setup_child prototype needs to go
somewhere.
Modified:
httpd/httpd/trunk/os/unix/unixd.h
Modified: httpd/httpd/trunk/os/unix/unixd.h
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/os/unix/
unixd.h?rev=739150&r1=739149&r2=739150&view=diff
=====================================================================
=========
--- httpd/httpd/trunk/os/unix/unixd.h (original)
+++ httpd/httpd/trunk/os/unix/unixd.h Fri Jan 30 02:48:08 2009
@@ -80,6 +80,8 @@
} unixd_config_rec;
AP_DECLARE_DATA extern unixd_config_rec ap_unixd_config;
+AP_DECLARE(int) ap_unixd_setup_child(void); /* mod_cgid needs
this */
+
Hm. This break compilation of trunk as this symbol is now added to
exports.c again
with no implementation in the core (only in a module).
It doesn't break my compilation in trunk -- I've done two complete
builds since then with no problems. Which platform and MPM? I have
been testing OS X 10.4.11 with prefork.
Where did it break with -Werror prior to this change?
Where it is first defined:
modules/arch/unix/mod_unixd.c
306:AP_DECLARE(int) ap_unixd_setup_child(void)
Note that the function is only called in a few old MPMs:
server/mpm/experimental/leader/leader.c
1023: if (ap_unixd_setup_child()) {
server/mpm/experimental/perchild/perchild.c
862: return ap_unixd_setup_child();
server/mpm/experimental/threadpool/threadpool.c
1246: if (ap_unixd_setup_child()) {
Can we move the function into those MPMs and just make it static?
Or maybe mpm_common.h?
....Roy
