Re: svn commit: r739382 - in /httpd/httpd/trunk: ./ include/ modules/filters/ modules/http/ modules/mappers/ modules/proxy/ server/

[Roy T. Fielding]

On Jan 31, 2009, at 1:53 AM, Ruediger Pluem wrote:

This causes the server to crash in case where no r->handler is set (e.g. in the case

of a non existing resource).

Bummer.  I suppose it would be too difficult to fix the couple hundred
places where strcmp is used on r->handler without checking for null.
No objection to applying the patch, but mod_include uses

    r->handler = "default-handler"

and others use symbols like

    r->handler = DAV_HANDLER_NAME;

perhaps we should use

    #define DEFAULT_HANDLER_NAME ""
    r->handler = DEFAULT_HANDLER_NAME;

and then fix the other places that are inconsistent.

....Roy