On May 12, 2009, at 2:53 PM, Ruediger Pluem wrote:



On 05/12/2009 05:10 PM, [email protected] wrote:
Author: jfclere
Date: Tue May 12 15:10:56 2009
New Revision: 773929

URL: http://svn.apache.org/viewvc?rev=773929&view=rev
Log:
Arrange the proxy_balancer_method:
- Put context back after the finder().
- Use  server_rec as second parameter for reset() and age().
- Add the call for reset().

Modified:
httpd/httpd/trunk/modules/proxy/balancers/ mod_lbmethod_bybusyness.c httpd/httpd/trunk/modules/proxy/balancers/ mod_lbmethod_byrequests.c
   httpd/httpd/trunk/modules/proxy/balancers/mod_lbmethod_bytraffic.c
   httpd/httpd/trunk/modules/proxy/balancers/mod_lbmethod_heartbeat.c
   httpd/httpd/trunk/modules/proxy/examples/mod_lbmethod_rr.c
   httpd/httpd/trunk/modules/proxy/mod_proxy.h
   httpd/httpd/trunk/modules/proxy/mod_proxy_balancer.c

Modified: httpd/httpd/trunk/modules/proxy/balancers/ mod_lbmethod_bybusyness.c
URL: 
http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/balancers/mod_lbmethod_bybusyness.c?rev=773929&r1=773928&r2=773929&view=diff
= = = = = = = = = ===================================================================== --- httpd/httpd/trunk/modules/proxy/balancers/ mod_lbmethod_bybusyness.c (original) +++ httpd/httpd/trunk/modules/proxy/balancers/ mod_lbmethod_bybusyness.c Tue May 12 15:10:56 2009
@@ -105,11 +105,11 @@

}

-static apr_status_t reset(proxy_balancer *balancer, request_rec *r) {
+static apr_status_t reset(proxy_balancer *balancer, server_rec *r) {

Could we please rename *r to*s?
*r for a server_rec is strange and IMHO wakes wrong associations.


That's why I didn't notice it :)

Reply via email to