On Jun 2, 2009, at 5:32 PM, William A. Rowe, Jr. wrote:
Here's an oddity to consider; FNM_PERIOD is part of the pattern match of both autoindex and ftp. In the case of autoindex, we default to a pattern NULL so there is no fnm pattern matching, and by default all files are autoindexed. But there is still an odd behavior; the first two of... http://localhost/foo/ http://localhost/foo/?P=* http://localhost/foo/?P=.* do not produce expected identities, but dot files can be listed as illustrated in the third example. In the mod_ftp case, ls is treated as ls *, not pattern NULL, so the second example above is triggered and dot files are hidden. It seems to me that neither module should use FNM_PERIOD, and there are other ways of not disclosing dot files where desired, and the pattern "*" should match the existing NULL behavior. Comments?
Likely moot right now (r779989) but +1 to either removing APR_FNM_PERIOD or changing pattern to NULL... the APR_FNM_PERIOD fix is likely better since the * pattern was a holder, iirc, from the old dir glob code.
