On 07/05/2009 04:45 PM, Guenter Knauf wrote: > Hi, > since one httpd version can link to a couple of different apr/apr-util > versions I find it useful to have these versions listed with mod_info, > and if nobody objects then I would like to apply a patch similar to the > one below (which is 2.2.x) to trunk, and then propose for backport into > 2.2.x: > > --- mod_info.c.orig Tue Nov 11 21:58:26 2008 > +++ mod_info.c Fri Jul 03 07:10:34 2009 > @@ -44,6 +44,7 @@ > #include "apr.h" > #include "apr_strings.h" > #include "apr_lib.h" > +#include "apr_version.h" > #define APR_WANT_STRFUNC > #include "apr_want.h" > > @@ -342,6 +343,9 @@ > server_rec *serv = r->server; > int max_daemons, forked, threaded; > > + ap_rputs(DOCTYPE_HTML_3_2 > + "<html><head>\n<title>Apache Info</title>\n</head><body>\n", > + r); > ap_rputs("<h2><a name=\"server\">Server Settings</a></h2>", r); > ap_rprintf(r, > "<dl><dt><strong>Server Version:</strong> "
No objections, but the above should not be part of the patch as the HTML header stuff is already done in mod_info and would be doubled. Regards RĂ¼diger