Bill, William A. Rowe, Jr. schrieb: > For trunk, it should be committed. Casts are generally signs of a dumb > compiler or poor coding design and must be avoided. done: http://svn.apache.org/viewvc?view=rev&revision=798989
> I'm generally -1 for stylistic cleanup backports. Although it might bring > trunk and the 2.2 branch into closer alignment, the fact is that they > diverge significantly enough not to sweat that. If an actual compilation or > cast/arg flaw is discovered on trunk, of course that should be backported. I've added to the new 2.2.x diff. > Almost compiles clean in all three on Win32 32 bit x86 architectures. > > For 1.0.0beta3; > > C:\local0\asf\build\httpd-2.2\modules\ssl\ssl_engine_init.c(1175) : warning > C4028: formal parameter 1 different from declaration > C:\local0\asf\build\httpd-2.2\modules\ssl\ssl_engine_init.c(1175) : warning > C4028: formal parameter 2 different from declaration > > Apparently this is bogus; > > static int ssl_init_FindCAList_X509NameCmp(X509_NAME **a, X509_NAME **b) > > It seems this solves the emits... > > static int ssl_init_FindCAList_X509NameCmp(const X509_NAME * const*a, > const X509_NAME * const*b) argh! I missed that, thanks! Its part of r749466 which I refered to, Now added to the 2.2.x diff, please review again: http://people.apache.org/~fuankg/diffs/openssl-1.x-2.2.x.diff > Well done :) I disagree since I missed the part above from r749466 :( Gün.
