[email protected] wrote:
> Author: rjung
> Date: Thu Sep 17 05:45:18 2009
> New Revision: 816061
> 
> URL: http://svn.apache.org/viewvc?rev=816061&view=rev
> Log:
> Fix
> - implicit declaration of function 'fchmod'
> - 'S_I[RWX](USR|GRP|OTH)' undeclared

Good catch, but...

> +#ifdef HAVE_FCHMOD
> +#ifdef HAVE_SYS_STAT_H
> +#include <sys/stat.h>
> +#endif
> +#endif

Grrr... this should *never* occur.  The HAVE_tests should not be
layered.  What is your question here?  (And this goes for your
commit to ftp_util.c as well.)  Is it FCHMOD or STAT_H?  Is it WIN32
or STAT_H?

Including a system header should be harmless, so you should be
dropping the overarching conditions.

Reply via email to