On 09/23/2009 10:10 PM, traw...@apache.org wrote: > Author: trawick > Date: Wed Sep 23 20:10:02 2009 > New Revision: 818234 > > URL: http://svn.apache.org/viewvc?rev=818234&view=rev > Log: > the request body size should be tracked and checked against > apr_off_t, not size_t and int > > Modified: > httpd/mod_fcgid/trunk/modules/fcgid/fcgid_bridge.c > httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c > httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.h >
> Modified: httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c > URL: > http://svn.apache.org/viewvc/httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c?rev=818234&r1=818233&r2=818234&view=diff > ============================================================================== > --- httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c (original) > +++ httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c Wed Sep 23 20:10:02 2009 > @@ -354,13 +354,35 @@ > return NULL; > } > > +static int strtoff(apr_off_t *val, const char *arg) > +{ > + char *errp; > + > +#if APR_MAJOR_VERSION < 1 > + *val = (apr_off_t)strtol(arg, &errp, 10); > + if (*errp) { > + return 1; > + } > +#else > + if (APR_SUCCESS != apr_strtoff(&conf->max_request_len, arg, &errp, 10) > || *errp) { Why not val here instead of &conf->max_request_len? Copy and paste error ? Regards Rüdiger
