On Sun, Sep 27, 2009 at 9:33 AM, Guenter Knauf <[email protected]> wrote:
> Hi Jie, > Jie Gao schrieb: > >> * Guenter Knauf <[email protected]> wrote: >> That worked. However, I am getting this: >> > good. Patch is already applied to 2.2.x branch. > > /usr/local/src/httpd-2.2.14/srclib/apr/libtool --silent --mode=compile >> /opt/SUNWspro/bin/cc -g -fast -DSOLARIS2=10 -D_POSIX_PTHREAD_SEMANTICS >> -D_REENTRANT -D_LARGEFILE64_SOURCE -DAP_DEBUG >> -I/usr/local/src/httpd-2.2.14/srclib/pcre -I. >> -I/usr/local/src/httpd-2.2.14/os/unix >> -I/usr/local/src/httpd-2.2.14/server/mpm/worker >> -I/usr/local/src/httpd-2.2.14/modules/http >> -I/usr/local/src/httpd-2.2.14/modules/filters >> -I/usr/local/src/httpd-2.2.14/modules/proxy >> -I/usr/local/src/httpd-2.2.14/include >> -I/usr/local/src/httpd-2.2.14/modules/generators >> -I/usr/local/src/httpd-2.2.14/modules/mappers >> -I/usr/local/src/httpd-2.2.14/modules/database >> -I/usr/local/src/httpd-2.2.14/srclib/apr/include >> -I/usr/local/src/httpd-2.2.14/srclib/apr-util/include >> -I/usr/local/src/httpd-2.2.14/srclib/apr-util/xml/expat/lib >> -I/usr/local/src/httpd-2.2.14/modules/proxy/../generators -I/usr/sfw/include >> -I/usr/local/src/httpd-2.2.14/modules/ssl >> -I/usr/local/src/httpd-2.2.14/modules/dav/main -prefer-pic -c ssl_e >> > ngine_io.c && touch ssl_engine_io.slo > >> "ssl_engine_io.c", line 1668: warning: enum type mismatch: arg #3 >> > woah - I love your strict compiler ... > > From what I seee we have here something wrong; line 1668 has: > rv = apr_brigade_split_line(bb, ctx->bb, mode, bytes); > but the prototype of apr_brigade_split_line() in APU13 apr_buckets.h is: > > APU_DECLARE(apr_status_t) apr_brigade_split_line(apr_bucket_brigade *bbOut, > apr_bucket_brigade *bbIn, > apr_read_type_e block, > apr_off_t maxbytes); > > so the 3rd arg should be of type apr_read_type_e, but we pass in > ap_input_mode_t .... - I assume the below is the correct fix: > > Index: ssl_engine_io.c > =================================================================== > --- ssl_engine_io.c (revision 819298) > +++ ssl_engine_io.c (working copy) > @@ -1665,7 +1665,7 @@ > } > else { > /* Split a line into the passed-in brigade. */ > - rv = apr_brigade_split_line(bb, ctx->bb, mode, bytes); > + rv = apr_brigade_split_line(bb, ctx->bb, block, bytes); > looks reasonable here; I guess that with this function the bucket is always in memory, so the potential mismatch of [non]blocking didn't have any operational impact
