On 10/08/2009 08:59 PM, Dan Poirier wrote: > I believe a couple of changes are needed in mod_cache to correctly > consider s-maxage in responses. I'd like to get the list's opinion > about it. > > First, currently if a GET or HEAD request with a query in the URI has a > response with Cache-control: s-maxage=NN, that response is not cached. >>From RFC 2616 13.9, 2nd paragraph, s-maxage specifies an explicit > expiration and so the response should be cached despite the query in the > URI. > > Second, currently a successful response with no Last-Modified, Etag, or > Expires headers is not cached. If it has Cache-control: max-age or > Cache-control: s-maxage, that specifies an expiration, and per RFC > 2616 13.4 we would expect it to be cached. > > I'm attaching a trunk patch that would implement these changes. >
Sound reasonable and looks fine (I mean the patch in the second mail of course :-)) Regards Rüdiger
