On Oct 12, 2009, at 5:15 PM, Brian J. France wrote:


On Oct 12, 2009, at 4:39 PM, Joe Orton wrote:

On Mon, Oct 12, 2009 at 04:17:00PM -0400, Brian J. France wrote:
On Oct 12, 2009, at 3:58 AM, Joe Orton wrote:
On Sat, Oct 10, 2009 at 10:04:57AM +0200, Ruediger Pluem wrote:
This creates the following warning:

repos.c:1827: warning: initialization from incompatible pointer type

Plus the dav_fs_get_request_rec prototype needs to be moved up.

/local/asf/httpd-trunk/modules/dav/fs/repos.c:214: warning: no
previous
prototype for ‘dav_fs_get_request_rec’

I don't know why that warning is happening. dav_fs_get_request_rec is
defined on line 214 and used in the struct on line 1827.

Sorry, my mistake, it's not a positioning problem - the function needs
to be made static.

Updated patch:


Scratch that, here is a patch:

Index: modules/dav/fs/repos.c
===================================================================
--- modules/dav/fs/repos.c      (revision 824480)
+++ modules/dav/fs/repos.c      (working copy)
@@ -211,7 +211,7 @@
 **
 ** PRIVATE REPOSITORY FUNCTIONS
 */
-request_rec *dav_fs_get_request_rec(const dav_resource *resource)
+static request_rec *dav_fs_get_request_rec(const dav_resource *resource)
 {
     return resource->info->r;
 }
@@ -1823,9 +1823,9 @@
     dav_fs_remove_resource,
     dav_fs_walk,
     dav_fs_getetag,
+    NULL,
     dav_fs_get_request_rec,
-    dav_fs_pathname,
-    NULL
+    dav_fs_pathname
 };

static dav_prop_insert dav_fs_insert_prop(const dav_resource *resource,

Reply via email to