Now we have a failure in the perl test suite: failed on html footer (C=S&O=A FancyIndexing) not ok 83 --- IndexOptions FancyIndexing IndexOrderDefault Descending Size
(C=S O=D) GET /modules/autoindex/htaccess/?C=S&O=D expect: -></body></html><- # Failed test 84 in t/modules/autoindex.t at line 114 fail #72 actual: -> </body><- failed on html footer (C=S&O=D FancyIndexing) not ok 84 FAILED tests 1-84 Failed 84/84 tests, 0.00% okay Failed Test Stat Wstat Total Fail Failed List of Failed ------------------------------------------------------------------------------- t/modules/autoindex.t 84 84 100.00% 1-84 Failed 1/1 test scripts, 0.00% okay. 84/84 subtests failed, 0.00% okay. [warning] server localhost:8529 shutdown [ error] error running tests (please examine t/logs/error_log) I assume this is because you added a \n between </body> and </html> in your patch. Could you please fix this such that we do not need to vary between different httpd versions in the test? Regards Rüdiger > -----Original Message----- > From: Rich Bowen [mailto:rbo...@rcbowen.com] > Sent: Dienstag, 26. Januar 2010 19:32 > To: dev@httpd.apache.org > Subject: Re: svn commit: r903052 - > /httpd/httpd/trunk/modules/generators/mod_autoindex.c > > > On Jan 26, 2010, at 02:05 , Ruediger Pluem wrote: > > > > > Please do not use C++ style comments as they fail on ANSI compilers. > > > Thank you. Fixed. > > -- > Rich Bowen > rbo...@rcbowen.com > > > >