On 2/15/2010 4:08 PM, Graham Leggett wrote: > On 15 Feb 2010, at 11:38 PM, Nick Kew wrote: > >> I think the point was, all the above happened after you'd committed. >> Maybe it would've been a good idea to discuss it first? > > To me, no, but not because I disagree with you, but rather because every > time we make a commit we make a call: is this small enough to warrant > commit-then-review, or is it big enough to warrant review-then-commit?
Something of the granularity of an entire *module* is certainly not 'small' at this project. In fact, after I took on chair of this project, I still proposed the small mod_remoteip for inclusion before I committed it to the httpd trunk. Small? Check. Simple? Check. But committing the project to maintaining a module after your code dump is no small matter; please ask first :)
