On Sat, May 1, 2010 at 7:48 AM, Stefan Fritsch <[email protected]> wrote: > On Monday 12 April 2010, Jeff Trawick wrote: >> attached are some compile fixes > > Thanks Jeff, I will include those fixes in the next round of patches. > It seems I should enable more modules when doing my testing. > > > How to proceed with these patches? From the people who have looked at > them already, is there anybody who thinks they are ready to be > commited to trunk? If no, what do you think should be changed?
I would like to see some buy-in for the API changes. I don't have any other concerns about committing. (Logging is such a part of main-line that many more people will see the changes in action while working on other issues, giving ample opportunity for necessary improvements/adjustments before 2.4 GA.) > Wrowe, at the Apache retreat you mentioned having an idea about how to > determine the module for the log messages in a more elegant way. Did > you have any chance to think about this some more? > > I think, instead of touching every file, it would be possible to have > a field in the module struct listing the filenames belonging to a > module. With some clever coding it should even be possible to do this > without having to do string compares during the logging. But I don't > think that this would be a better solution. For example, there can be > duplicate filenames (we already have two util.c files). For selection by module, does the facility need to be more granular than simply using the canonical source file name -- the name of the file that declares the module struct?
