On 5/5/2010 3:07 PM, William A. Rowe Jr. wrote: > On 5/4/2010 3:00 PM, Jeff Trawick wrote: >> >> I haven't looked at mod_mutex, but no big concerns here; the API is >> useful; I'd guess some module authors would be relieved to use that >> feature if their users currently have mutex issues that require >> configuration, and the module doesn't already provide that > > Or when their module code is dodgy, let's face it, until this API, things > haven't been easy for handling mutexes. > > There is a disadvantage of this code, improvements welcome; you'll find > a module using ap_global_mutex_create will emit; > > /usr/include/apache2/util_mutex.h:209: warning: 'ap_proc_mutex_create_ptr' > defined but not > used > > and visa versa for proc users. Ideas?
I flipped these from being module-static datum to creating light static wrapper functions with internally static storage, and at least on gcc 4.2.1 it's quieted down the warnings entirely. See the new alternative .h file; http://people.apache.org/~wrowe/util_mutex.h.2
