Hi all,
Another API observation, this time with mod_include.
The generic include_ctx_t structure that is handed to include
operations doesn't include request_rec. While mod_include itself has a
private structure that keeps track of request_rec, this isn't
available to external modules.
Ideally, I'd like to change the API to look like this:
Index: mod_include.h
===================================================================
--- mod_include.h (revision 952862)
+++ mod_include.h (working copy)
@@ -96,6 +96,10 @@
/* pointer to internal (non-public) data, don't touch */
struct ssi_internal_ctx *intern;
+
+ /* the current request */
+ request_rec *r;
+
} include_ctx_t;
typedef apr_status_t (include_handler_fn_t)(include_ctx_t *,
ap_filter_t *,
Thoughts?
Regards,
Graham
--
