On 3/23/2011 6:16 PM, NormW wrote: > Hi, > apr-trunk needs a tweak similar to below to build (for NetWare anyway) using > Expat 2.0.1 > source: > > --- apr_xml_expat.c.orig 2011-03-24 07:07:47.187500000 +1100 > +++ apr_xml_expat.c 2011-03-24 10:00:01.781250000 +1100 > @@ -17,7 +17,6 @@ > #include "apr.h" > #include "apr_xml.h" > > -typedef enum XML_Error XML_Error; > #if defined(HAVE_XMLPARSE_XMLPARSE_H) > #include <xmlparse/xmlparse.h> > #elif defined(HAVE_XMLTOK_XMLPARSE_H) > @@ -28,6 +27,7 @@ > #include <expat.h> > #endif > > +typedef enum XML_Error XML_Error; > > #include "apr_xml_internal.h" > > ...and if someone is passing by svn apr-trunk xml dir, some Win compat eol's > would be nice > on the new additions please. Will see how far I can get with an XML2 build.
So if this is not in the .h's (and without namespace protection it has no place in our .h's), can we just 'not do that' and fully declare all our 'enum XML_Error' results, please? I think that's the better patch.