On Mon, Mar 28, 2011 at 12:35 AM, William A. Rowe Jr. <wr...@rowe-clan.net> wrote: > On 3/27/2011 7:39 PM, Guenter Knauf wrote: >> Am 28.03.2011 01:57, schrieb Jeff Trawick: >>> On Sun, Mar 27, 2011 at 7:51 PM,<traw...@apache.org> wrote: >>>> Author: trawick >>>> Date: Sun Mar 27 23:51:18 2011 >>>> New Revision: 1086073 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=1086073&view=rev >>>> Log: >>>> enable DEFAULT_REL_RUNTIMEDIR on NetWare and Windows >>>> >>>> this commit is missing the Windows and NetWare build >>>> logic to copy the appropriate file to include/ap_config_layout.h >>> >>> just so the info isn't trapped inside another thread: >>> >>> Windows: a change is needed (perhaps to libhttpd.dsp) to copy >>> os/win32/win32_config_layout.h to include/ap_config_layout.h >>> NetWare: something similar >> with other headers we do usually just append w|nw to the extensision, and >> have these files >> in same directory as where the target should live, f.e.: >> include/ap_config_layout.h (target) >> include/ap_config_layout.hw (windows) >> include/ap_config_layout.hnw (netware) >> >> then at least for NetWare where we use GNU make a simple generic rule: >> %.h : %.hnw >> copy $< $@ >> >> does the job (we use this already with APR/APU too) ... >> >> I dont say that the copy with those files you commited is of any problem, >> just wanted to >> mention what existing logic we currently have already with other headers ... >> awaiting Bill's comment on that ...
FWLIW, I thought of that, but decided not to when I found no .hw or .hnw within httpd. Go for it! > +/-0, I'm happy either way, I'll commit the build update in the morning > whether > the source file is named os_layout.h or ap_config_layout.hw :)
