On 26.04.2011 21:57, Jeff Trawick wrote:
On Sun, Jan 9, 2011 at 6:00 PM,<s...@apache.org> wrote:
Author: sf
Date: Sun Jan 9 23:00:33 2011
New Revision: 1057048
URL: http://svn.apache.org/viewvc?rev=1057048&view=rev
Log:
mod_status: Don't show slots which are disabled by MaxClients as open.
They now get displayed as ' ' instead of '.'.
No complaints here about not displaying unused slots as open, but the
result can look a bit odd.
---------cut here-----------
1 requests currently being processed, 49 idle workers
_________________________
______W__________________
Scoreboard Key:
-----------cut here--------------
On Windows, with huge default ThreadLimit relative to ThreadsPerChild,
you're left with lots of unexpected whitespace.
What about just surpressing the ' ' when printing out the worker map?
After a graceful restart which shrinks MaxClients or ThreadsPerChild
you might have the map gradually get smaller for a short time as
workers in those "beyond" scoreboard entries exit, but generally it
would look better.
Comments? (Do folks want the space used to reflect ThreadLimit * ServerLimit?)
Modified: httpd/httpd/trunk/modules/generators/mod_status.c
URL:
http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/generators/mod_status.c?rev=1057048&r1=1057047&r2=1057048&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/generators/mod_status.c (original)
+++ httpd/httpd/trunk/modules/generators/mod_status.c Sun Jan 9 23:00:33 2011
@@ -483,7 +492,8 @@ static int status_handler(request_rec *r
ap_rputs("\"<b><code>L</code></b>\" Logging, \n", r);
ap_rputs("\"<b><code>G</code></b>\" Gracefully finishing,<br /> \n",
r);
ap_rputs("\"<b><code>I</code></b>\" Idle cleanup of worker, \n", r);
- ap_rputs("\"<b><code>.</code></b>\" Open slot with no current
process</p>\n", r);
+ ap_rputs("\"<b><code>.</code></b>\" Open slot with no current process,<br
/>\n", r);
+ ap_rputs("\"<b><code> </code></b>\" Slot disabled by MaxClients
setting</p>\n", r);
(and/or by ThreadsPerChild)
I'd say the additional slots are more of an implementation detail
(pre-allocated to allow increasing the actual available processes and
threads by graceful restart) and do not provide relevant information for
mod_status. So I am +1 for dropping, but can live with white space too.
Regards,
Rainer
