On 5/18/2011 12:34 PM, Philip M. Gollucci wrote: >> Modified: httpd/httpd/trunk/include/httpd.h >> URL: > http://svn.apache.org/viewvc/httpd/httpd/trunk/include/httpd.h?rev=1082196&r1=1082195&r2=1082196&view=diff >> > ============================================================================== >> --- httpd/httpd/trunk/include/httpd.h (original) >> +++ httpd/httpd/trunk/include/httpd.h Wed Mar 16 16:45:25 2011 >> @@ -1496,7 +1496,7 @@ AP_DECLARE(int) ap_unescape_url(char *ur >> * @param url The url to unescape >> * @return 0 on success, non-zero otherwise >> */ >> -AP_DECLARE(int) ap_unescape_url_keep2f(char *url); >> +AP_DECLARE(int) ap_unescape_url_keep2f(char *url, int decode_slashes); > > Did we mean to change a public API in a patch release ? .17 -> .18 ? > This has broken things in FreeBSD ports and is being reported a bit. > I see the mmn bump so you can detect it at least.
If this was backported, that's bad. We proclaim binary compatibility within any stable sub-rev release. Sorry that I did not catch this. http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/include/httpd.h?r1=1076611&r2=1082630 I suggest we revert in 2.2.19 and consider this .18 an aberration/broken release. I would offer to tag and roll today. Those who wish to work around it, may, but a quick reaction would allow folks to avoid it. Other thoughts?
