Hi,
from time to time I prepare small patches to improve apache code source
quality.
These patches can be small speed up, removal of duplicated code, clean-up,
formatting... But no functionnal change as I'm not an apache guru yet.
This is more or less like what is done by the kernel janitors for linux.
Once I'd been told to use the apache bugzilla database to submit these
patches, but, I'm not sure that this is the best place.
Patches like the following one are, IMO, a good thing. It improves
readability of the source code, reduce number of lines, reduce potential
mistakes... But bugzilla is not dedicated for this kind of patch.
>>>>>>>>>>>>>>>>
Index: modules/filters/mod_include.c
===================================================================
--- modules/filters/mod_include.c (revision 1132846)
+++ modules/filters/mod_include.c (working copy)
@@ -3230,10 +3217,7 @@
char *sp = intern->current_arg->name;
/* normalize the name */
- while (*sp) {
- *sp = apr_tolower(*sp);
- ++sp;
- }
+ ap_str_tolower(sp);
}
intern->state = PARSE_ARG_EQ;
>>>>>>>>>>>>>>>>
So I was wondering if 'comp.apache.devel' could be the right place ?
Or maybe a new dedicated forum could be created, for example
'comp.apache.janitor' ?
Or maybe patches could be sent directly to main developpers of apache for
approval or refusal ?
On the other side, do you think that this kind of patch are usefull and
worse submitting ?
Thanks for your comments.
CJ
