On 30/06/2011 5:31 AM, Stefan Fritsch wrote:
On Wednesday 29 June 2011, Stefan Fritsch wrote:
This doesn't build for me because LDAP_DECLARE is not defined for
Fixed in r1141201, more testers welcome.
For 2.3.13, my vote is -1. With r1141201, it would have been +1.
But I think it may be good if one Windows and one Netware person could
test 2.3.13 + patch, just to make sure that the next tarball won't
fail there.
Guess I'd do as a NetWare person though not an 'official' one.
ATM NetWare build of httpd-trunk is 'broken' as there has been no
updates to its Makefiles since httpd acquired LDAP. I did send a diff
some days ago, but it never got an official blessing so I assume it has
been dropped.
The NWGNU Makefile changes are easily handled but ap_ldap_rebind.c has
some NetWare specific code that MAY not (now) be needed as it MAY have
been something specific to APR use. (If the NetWare code is removed then
it does build, but there may be subtleties I'm unaware off.)
One point of query is the inclusion of:
/* this will be defined if LDAP support was ..... */
#define AP_HAS_LDAP 1
in both ap_ldap.hw and ap_ldap.hnw since (to my logic) AP_HAS_LDAP is a
compile-time option that ought to omit all LDAP pieces from the build if
set 0, so having it in these files and then a few lines later have #if
AP_HAS_LDAP makes no sense.
HTH,
Regards
Norm
