On 8/3/2011 11:23 AM, Kaspar Brand wrote: > Ok, so the initial version of that patch became relatively large: > > https://people.apache.org/~kbrand/mod_ssl-toolkit-support.v1.diff > > Even though trunk is CTR, I'm somewhat reluctant with simply going ahead > and would appreciate if people could comment on this approach (e.g. if > it's fine or splitting up would be preferred, etc.). > > In theory, the changes could be limited to the autoconf stuff - i.e., > guard against OpenSSL < 0.9.7 and not detect BSAFE SSL-C any longer in > configure, and leave the mod_ssl code as is, mostly. > > I don't think that's what we want, however, so I tried to get rid of as > much of the macro cruft as possible (drop ssl_toolkit_compat.h, remove > obsolete ifdef'ed code and so on).
My thought, it probably should be a set of commits; * Drop SSLC (first patch) * Drop OpenSSL < 0.9.7 (second patch) * Drop ssl_toolkit_compat wrapper (third patch) * Warn on 0.9.7 and some 0.9.8 flavors (last patch)
