Thanks. Will review and vote.
Regards
Rüdiger
> -----Original Message-----
> From: Rainer Jung
> Sent: Donnerstag, 29. September 2011 14:36
> To: dev@httpd.apache.org
> Subject: Re: svn commit: r1176019 - in /httpd/httpd/trunk:
> CHANGES modules/filters/mod_substitute.c
>
> On 29.09.2011 13:09, "Plüm, Rüdiger, VF-Group" wrote:
> > Anyone time for remote eyes if my findings are correct or wrong?
>
> I did only locally check the scratch and fbytes stuff, but I agree, it
> must be
>
> Index: modules/filters/mod_substitute.c
> ===================================================================
> --- modules/filters/mod_substitute.c (revision 1177244)
> +++ modules/filters/mod_substitute.c (working copy)
> @@ -213,7 +213,7 @@
> * we've allocated and only re-alloc
> when we need it.
> * NOTE: this screams for a macro.
> */
> - if (!scratch || (bytes > (fbytes + 1))) {
> + if (!scratch || (bytes + 1 > fbytes)) {
> fbytes = bytes + 1;
> scratch = apr_palloc(tpool, fbytes);
> }
>
> Will propose for 2.2.x.
>
> Regards,
>
> Rainer
>
