----- Original Message ----- > On 23 Nov 2011, at 10:13 PM, Stefan Fritsch wrote: > > >> - return OK; > >> + return ap_pass_brigade_fchk(r, out, > >> + apr_psprintf(r->pool, > >> + > >> "cache_quick_handler(%s): > >> ap_pass_brigade returned", > >> + > >> cache->provider_name)); > >> } > > > > This means we call apr_psprintf even if everything went well. > > That's far from optimal. Maybe really make it into a macro, then > > the apr_psprintf would only be executed on error? > > Or perhaps use varargs for the message?
+1 > Regards, > Graham > -- -- Igor Galić Tel: +43 (0) 664 886 22 883 Mail: [email protected] URL: http://brainsware.org/ GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE
