Eric Covener wrote:
>> The different handling of conn->port and conn->hostname doesn't look
>> right to me. Can the r->proxyreq check actually be false at this point or is
>> it simply redundant? And shouldn't the strcasecmp(conn->hostname,
>> uri->hostname) check be done regardless of r->connection->keepalives?
> 
> I did not understand the r->keepalives "optimization", maybe comparing
> hostnames could just come last.
> 

I don't think that this "optimization" is valid, because this can IMHO lead to
a situation where a non keepalive frontend connection reuses the wrong backend
connection. Keepalives between frontend and backend connections are decoupled.

So it should be simply removed.


Regards

Rüdiger

Reply via email to