On Fri, Jun 01, 2012 at 11:31:55AM +0200, Ruediger Pluem wrote: > jor...@apache.org wrote: > > --- httpd/httpd/trunk/configure.in (original) > > +++ httpd/httpd/trunk/configure.in Wed May 23 15:42:33 2012 > > @@ -703,7 +703,24 @@ APACHE_HELP_STRING(--with-suexec-gidmin, > > > > AC_ARG_WITH(suexec-logfile, > > APACHE_HELP_STRING(--with-suexec-logfile,Set the logfile),[ > > - AC_DEFINE_UNQUOTED(AP_LOG_EXEC, "$withval", [SuExec log file] ) ] ) > > + if test "x$withval" = "xyes"; then > > Shouldn't that be > > if test "x$withval" != "xno" -a "x$withval" != "x"; then > > otherwise AP_LOG_EXEC gets only defined if --with-suexec-logfile=yes and not > if > --with-suexec-logfile=/someplace/somefile
Good catch, yes, this was wrong. If --with-foo is given without an argument, withval is set to "yes", so I've made it fail for that case. http://svn.apache.org/viewvc?rev=1345147&view=rev Regards, Joe
