On 17.04.2013 11:38, Plüm, Rüdiger, Vodafone Group wrote: > > >> -----Original Message----- >> From: André Malo [mailto:n...@perlig.de] >> Sent: Mittwoch, 17. April 2013 11:04 >> To: dev@httpd.apache.org >> Subject: Re: svn commit: r1461869 - /httpd/httpd/trunk/server/util.c >> >> * Rainer Jung wrote: >> >>> >> http://people.apache.org/~rjung/patches/ap_escape_logitem_enhanced.patch >> >> + ret = apr_palloc(p, length + 3 * escapes); >> >> It should be still 4 * escapes ('\xHH'). > > I don't think so. If you have the binary data of \xHH it is ok to have one > byte for the original data > plus 3 bytes for the escapes and that is length + 3 * escapes. The storage > for the original data is in > length. But I admit that I got confused by that as well :-)
So probably we should use a better comment as the one in the patch currently: /* 3 * escapes for the overhead in '\\' + c2x() */ ;) Rainer
